User:Chani/WayOfThePlasma/Categories/Policy

From KDE TechBase
Revision as of 17:47, 13 March 2008 by Mmauder (talk | contribs) (why peer-review)
(diff) ← Older revision | Latest revision (diff) | Newer revision → (diff)

Why must patches be peer-reviewed before they can be commited?

Conclusion

It is hard for new contributers to see all possible consequences of the changes they introduce. This has lead to long-term issues in earlier projects.

Original Text

Aaron Seigo

  • now, last week saw many unreviewed commits that actually resulted in rather unecessary issues in the code base; (...) people have a tendency to fall back to methods that got us kicker and kdesktop (namely: really useful programs that did a ton of a stuff but were at a point where they hit a brick wall as far as being able to take them further).
  • free-for-all does have a very negative impact on the code base. we tried that, and we moved to peer review because of what that resulted in.

Sources

panel-devel archive (2008-02)