KDE PIM/MS Windows/SQLite Folder Indices/merge: Difference between revisions

    From KDE TechBase
    No edit summary
    No edit summary
    Line 1: Line 1:
    Validation of the SQLite folder indices merge into kdepim trunk ([http://websvn.kde.org/?view=rev&revision=805075 805075]).
    Validation of the SQLite folder indices merge into kdepim trunk ([http://websvn.kde.org/?view=rev&revision=805075 805075]).


    *compactionjob.cpp
    "OK" means files or methods inspected in every detail.
     
    *compactionjob.cpp - OK
    **void MboxCompactionJob::done( int rc ): the only addition result of KDE_rename() is checked, return immediately on failure
    **void MboxCompactionJob::done( int rc ): the only addition result of KDE_rename() is checked, return immediately on failure
    **status: OK
    **status:  


    *folderstorage.cpp
    *folderstorage.cpp
    Line 37: Line 39:
    *kmmsginfo.h
    *kmmsginfo.h


    *messageproperty.cpp
    *messageproperty.cpp - OK
    **minor optimizations only added, for example 1. instead of 2.:
    **minor optimizations only added, for example 1. instead of 2.:
    **#QMap<quint32, QPointer<KMFolder> >::ConstIterator it = sFolders.constFind( serNum );<br/>return it == sFolders.constEnd() ? 0 : (*it).operator->();
    **#QMap<quint32, QPointer<KMFolder> >::ConstIterator it = sFolders.constFind( serNum );<br/>return it == sFolders.constEnd() ? 0 : (*it).operator->();

    Revision as of 09:09, 8 May 2008

    Validation of the SQLite folder indices merge into kdepim trunk (805075).

    "OK" means files or methods inspected in every detail.

    • compactionjob.cpp - OK
      • void MboxCompactionJob::done( int rc ): the only addition result of KDE_rename() is checked, return immediately on failure
      • status:
    • folderstorage.cpp
    • folderstorage.h
    • kmailicalifaceimpl.cpp
    • kmfolder.cpp
    • kmfolder.h
    • kmfolderdir.cpp
    • kmfolderindex.cpp
    • kmfolderindex.h
    • kmfoldermaildir.cpp
    • kmfoldermbox.cpp
    • kmfoldersearch.cpp
    • kmheaders.cpp
    • kmheaders.h
    • kmkernel.cpp
    • kmmsgbase.cpp
    • kmmsgbase.h
    • kmmsgdict.cpp
    • kmmsginfo.cpp
    • kmmsginfo.h
    • messageproperty.cpp - OK
      • minor optimizations only added, for example 1. instead of 2.:
        1. QMap<quint32, QPointer<KMFolder> >::ConstIterator it = sFolders.constFind( serNum );
          return it == sFolders.constEnd() ? 0 : (*it).operator->();
        2. if (sFolders.contains(serNum))
            return sFolders[serNum].operator->();
          return 0;
      • Affected methods:
        • KMFolder* MessageProperty::filterFolder( quint32 serNum ) - Status: OK
        • ActionScheduler* MessageProperty::filterHandler( quint32 serNum ) - Status: OK
        • bool MessageProperty::transferInProgress( quint32 serNum ) - Status: OK
        • void MessageProperty::setTransferInProgress( quint32 serNum, bool transfer, bool force ) - Status: OK
        • quint32 MessageProperty::serialCache( const KMMsgBase *msgBase ) - Status: OK