Difference between revisions of "Infrastructure/Review Board"

(→‎Closing a review request: Improving example, showing one can add a comment to the "REVIEW: nnn" line)
(Replaced content with "https://community.kde.org/Infrastructure/Review_Board")
(8 intermediate revisions by 5 users not shown)
Line 1: Line 1:
= KDE Review Board =
KDE currently uses the [http://www.reviewboard.org/ Review Board] software for performing reviews on code changes.
There are separate versions of Review Board for use with Git and Subversion:
* [http://git.reviewboard.kde.org KDE Git Review Board]
* [http://svn.reviewboard.kde.org KDE Subversion Review Board]
Note that http://reviewboard.kde.org/ redirects to the Git version.
== Using Review Board and post-review with Git ==
Every Git Project repository has its own entry on the KDE Git Review Board.
=== Creating your changeset ===
To create your changeset, you probably want to work in a separate branch - or even in your clone. This is actually suggested and the proper way to do changesets in Git. You can create any number of commits, amend them, and do whatever you want to do - it won't affect the next steps, as you will submit the whole branch for review.
Before proceeding it is good practice to rebase your branch onto the branch you want to target for the merge. So, supposing you want to target <tt>master</tt>, make sure it is up-to-date with the remote and then run, and want to publish a review for a local branch:
git pull --rebase
If you want to post a review for merging a non local branch, you might want to run the following:
git merge master
=== Using post-review to post changes for review ===
Once you are done with the above, it is time to post the changes to ReviewBoard. The easiest and most comfortable way to do that is <tt>[http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/ post-review]</tt>, a handy command line tool which takes care of creating review requests for you. This is normally in a package called RBTools, available as [http://software.opensuse.org/search?q=rbtools <code>rbtools</code> in OpenSuse's devel:tools repository] and as
sudo apt-get install python-rbtools
in Debian/Ubuntu.
==== Prerequisites ====
The following has to be done only once to make your local clone fit for use with <tt>post-review</tt>.
First of all, you have to tell it about the ReviewBoard server. If your project does not ship with a <tt>.reviewboardrc</tt> file (encourage the project manager to add one!), the first thing you have to run is:
git config reviewboard.url https://git.reviewboard.kde.org
ReviewBoard currently only knows the project repositories by their git:// URLs, making it necessary to have a remote using the git:// URL in your clone. If your <tt>origin</tt> remote is already using the git:// URL, you are all set. If not you need to add another remote now.
Let's suppose you are looking to have some changes to [https://projects.kde.org/projects/extragear/multimedia/amarok Amarok] reviewed, and the URL of your <tt>origin</tt> remote is <tt>[email protected]:amarok</tt>. To add another remote using the git:// URL you might run:
git remote add anonupstream git://anongit.kde.org/amarok
git fetch anonupstream
If your <tt>origin</tt> remote was already using the git:// url, substitute <tt>anonupstream</tt> with <tt>origin</tt> throughout the rest of this tutorial.
If you used a <tt>kde:</tt> prefix for your git remotes, post-review won't expand it (it uses <tt>git config --get remote.origin.url</tt>).
This can be fixed by editing 
and at the end of the function "def get_origin", adding the following line before the return line:
<tt>origin_url = origin_url.replace("kde:", "git://anongit.kde.org/")</tt>
==== Creating the review request ====
You are now ready to create the review request. The <tt>post-review</tt> command should look something like this:
post-review --parent=master --tracking-branch=anonupstream/master
This command tells <tt>post-review</tt> that your branch is based upon <tt>master</tt>, and it is set to track the remote branch <tt>anonupstream/master</tt>. You can also give <tt>post-review</tt> some more arguments to avoid using the web interface later - have a look at the [http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/ user manual] for more on that.
After the command has been run a web address will be shown in the terminal, pointing at your review request.
==== Updating a review request ====
If you need to update an existing review request you can invoke <tt>post-review</tt> with an additional <tt>-r</tt> argument, which should be the numeric id of the review request you want to update. Supposing you want to update review request 54, you would run:
post-review --parent=master --tracking-branch=anonupstream/master -r 54
==== Create a convenient git alias ====
To reduce the typing needed you can create a git alias with the options you use for post-review. Add the line
below to the <tt>[alias]</tt> section of your ~/.gitconfig file.
post-review = !post-review --guess-summary --guess-description --username=<YOUR USERNAME> --parent=master --tracking-branch=anonupstream/master
Now you can submit a committed patch for review by just typing
git post-review
If you want to amend an already existing review request just add <tt>-r NUM</tt> to the end of the command.
==== Creating a ReviewBoard-compatible diff ====
In some rare cases you simply want to generate a diff and submit it to ReviewBoard later. You can do that by running:
post-review --parent=master -n > your-patch.patch
=== Closing a review request ===
A review request can be closed in two ways. Either the user who opened the review request can use the ReviewBoard web interface. Or you close the review right in a GIT commit. This is done by using the REVIEW keyword followed by the review ID you want to close in a separate line. Add a description of the fix in the following lines. For example, to close review 54, you would put
Fixing crash due to an uninitialized pointer when opening a file
in your commit. A message will also be posted to ReviewBoard indicating the commit SHA1 that closed the request. Please note that this only works for GIT commits, and not for Subversion commits.
You can use this command to add REVIEW keyword to existing git log:
git rebase --interactive
== Using Review Board With Subversion ==
Not all KDE Subversion projects use Review Board so first you need to check if the project you've created the patch for is actually using reviewboard. For this, go to the [http://svn.reviewboard.kde.org/groups/ groups section] and see if the project's group is listed there. If it is listed there, you should use the reviewboard, otherwise send the patch by other means.
For sending a patch, you first need to register. Then simply click ''[http://svn.reviewboard.kde.org/r/new/ New Review Request]'' and fill out the form. The most important parts of the form are:
* '''The actual patch'''. You need to upload the patch you've created earlier here
* '''The SVN base path'''. This is needed for the inline patch display to work. This can be a bit tricky, if you are unfamiliar with KDE's SVN layout, check [http://websvn.kde.org WebSVN]. For example, if you're ''svn diff'ing'' from <tt>/path/to/your/copy/of/kdelibs/cmake/modules</tt>, the base path should be <tt>/trunk/KDE/kdelibs/cmake/modules</tt>. If you still don't know the correct base path, ask a developer on IRC. You can also edit the review request later.
* '''A summary of the patch'''. This should be short, it will show up as subject of the notification emails.
* '''A description of the patch'''. This can be longer.
* '''The group(s)'''. Make sure you enter the correct group '''ID''' here, as seen earlier on the [http://reviewboard.kde.org/groups/ groups page].
After you completed the form, a notification mail will be sent to the developers and they will answer you.
/!\ You need to use svn diff in english, if your system is not english, please do LC_ALL=C svn diff

Latest revision as of 11:39, 9 March 2016

This page was last edited on 9 March 2016, at 11:39. Content is available under Creative Commons License SA 4.0 unless otherwise noted.