Projects/KHTML: Difference between revisions

Latest revision as of 19:33, 19 November 2008

In-progress bugfixes

SadEagle:bug #169988 --- focus/blur on all elements, head/body parsing #?????, multiple problems with onchange (bug #170451, many others)
- head/body parsing : bug #170694 ?

Acid3 stuff

See Projects/Acid3

Major targets

SVG --- vtokarev
DOM namespace changes --- vtokarev --- done (in trunk)
Class attribute hashconsing for improved css selectors performance --- vtokarev
- Implementation that we have currently is significantly slower on specific test case (probably less on real-life pages). Anyway, it should improve performance (maybe even memory usage), with small drawback on complexity
HTML5 Audio/Video --- Spart
getComputedStyle w/display:none --- SadEagle
- Acid3 #35/#41, bug #169617
iframe stuff --- SadEagle, non-immediate
- XSS permissions for about: and javascript: URL affect tinyMCE
canvas --- SadEagle, non-immediate:
- New params to putImageData, createImageData, parameter checking updates
- Depends on getComputedStyle:
  - Add support for currentColor
  - text

Potentially high-impact bugs

derstandard.at
tokenizer script-recursion crashes - (what bug #? (Spart))
- Might not be a good name, but I mean: bug #170185, part of bug #165601, part of bug #162498, later bts and dupes of bug #145666, and likely some others. My initial description is probably wrong, though --- the problem is the hack in handling window.document that creates the document by calling begin/write/end is doing so on a document with a parser active; one of the triggers is probably because the restoration of frames from KHTMLPageCache may happen in the wrong order, but the various reports suggest it's not the only case. (The reason for the original description is that I recalled seeing quite a few reports mentioning the same m_scriptExecuting assert, e.g. bug #118104 for a long time, and figured it's time to get rid of this; some of those are actually mixed in with the dupes of the above). -S.E.
  - I analyzed this some more, and it's very hard to fix; basically the whole restoreState on multiple frames thing is broken, as it tries to restore kids independently of parents, and each may have <script> fragments, etc. The code likely needs to be reworked to do deferred application of saved info such as scroll position, etc., once loaded. -Maks

@@ Line 1: / Line 1: @@
 === In-progress bugfixes ===
 * SadEagle:{{Bug|169988}} --- focus/blur on all elements, head/body parsing #?????, multiple problems with onchange ({{Bug|170451}}, many others)
-** onchange on lineedit/textarea isn't called because handleFocusOut isn't called for redirected widgets
+** head/body parsing : {{Bug|170694}} ?
-*** would something like http://rafb.net/p/ikWvHK97.html do? I didn't actually tested the patch for lack of a testcase though.(Sp.)
-* working on integrating changes in 4.1.2 ChangeLog (Sp.)
-** Woops, done that already. Sorry. -Maks.
-*** bah, nevermind... I'm too slow. Thank you.(Sp.)
-* need to add/update several testcases in regression suite for 4 or 5 five bug fixes (Sp.)
-* got a patch for fixing most of the trivial problems reported on core-devel by C.Bartoschek (Sp.)
 === Acid3 stuff ===
@@ Line 14: / Line 8: @@
 === Major targets ===
 * SVG --- vtokarev
-* DOM namespace changes --- vtokarev
+* DOM namespace changes --- vtokarev --- done (in trunk)
+* Class attribute hashconsing for improved css selectors performance --- vtokarev
+** Implementation that we have currently is significantly slower on specific test case (probably less on real-life pages). Anyway, it should improve performance (maybe even memory usage), with small drawback on complexity
 * HTML5 Audio/Video --- Spart
 * getComputedStyle w/display:none  --- SadEagle
@@ Line 27: / Line 23: @@
 === Potentially high-impact bugs ===
-* Selection crashes, affecting at least Kopete {{Bug|170749}}, seen elsewhere, too (I believe I fixed this some times ago.. r855319 {{Bug|167239}} - needs test (Spart))
 * derstandard.at
 * tokenizer script-recursion crashes - (what bug #? (Spart))
 ** Might not be a good name, but I mean: {{Bug|170185}}, part of {{Bug|165601}}, part of {{Bug|162498}}, later bts and dupes of {{Bug|145666}}, and likely some others. My initial description is probably wrong, though --- the problem is the hack in handling window.document that creates the document by calling begin/write/end is doing so on a document with a parser active; one of the triggers is probably because the restoration of frames from KHTMLPageCache may happen in the wrong order, but the various reports suggest it's not the only case. (The reason for the original description is that I recalled seeing quite a few reports mentioning the same m_scriptExecuting assert, e.g. {{Bug|118104}} for a long time, and figured it's time to get rid of this; some of those are actually mixed in with the dupes of the above). -S.E.
-* QWidget::scroll bug ({{Bug|167739}}) - ouch, I just discovered the BR and the analysis... that explain why the performance was so low on random pages. Need to use QWidget::scroll with a rect argument on Scrollarea's widget(), but also need to fix the associated Qt bug/inefficiency - doing that now (S.)
+*** I analyzed this some more, and it's very hard to fix; basically the whole restoreState on multiple frames thing is broken, as it tries to restore kids independently of parents, and each may have <script> fragments, etc. The code likely needs to be reworked to do deferred application of saved info such as scroll position, etc., once loaded. -Maks
-** solved - will prepare a qt-copy patch
-* Sometimes changing pages doesn't repaint properly, leaving parts of the old one. I've seen it on lists.kde.org, but can't reproduce now , here is one reproducible (r855004 on branch)testcase, though (but this one uses frames, not standalone) (-S.E.):
-** 1. Go to http://www.cs.cornell.edu/courses/cs3810/2008fa/
-** 2. Click on Grading/HW
-** 3. Scroll down.
-** 4. Click on Grading/HW again -- much of the frame isn't repainted