https://techbase.kde.org/api.php?action=feedcontributions&user=Neoclust&feedformat=atomKDE TechBase - User contributions [en]2024-03-29T10:02:53ZUser contributionsMediaWiki 1.40.2https://techbase.kde.org/index.php?title=Projects/English_Breakfast_Network&diff=75169Projects/English Breakfast Network2012-09-01T16:38:48Z<p>Neoclust: </p>
<hr />
<div><br />
<br />
The [http://www.englishbreakfastnetwork.org/ English Breakfast Network (EBN)] is a site dedicated to KDE Quality, including: KDE API Documentation Validation, User Documentation Validation and Source Code Checking.<br />
<br />
== Related Links ==<br />
* [http://techbase.kde.org/Development/Tutorials/Code_Checking Krazy]<br />
* [http://techbase.kde.org/Development/Tutorials/Localization/i18n_Krazy i18nc checks]<br />
<br />
== Tools ==<br />
=== Code Checking (Krazy) ===<br />
* dpointers - Make sure that installed class headers have dpointers.<br />
=== APIDOX ===<br />
=== Doc Sanitizer ===<br />
=== Coverage ===<br />
<br />
==Things To-do==<br />
* Web Pages and Server Stuff<br />
<br />
* Krazy<br />
** Web Stuff<br />
*** Say when the next update will be run<br />
*** Put the output 'krazy --list --explain --export=ebn' someplace?<br />
** Tutorials http://techbase.kde.org/Development/Tutorials/Code_Checking<br />
*** Document .krazy files<br />
*** How to get the names of the plugins (in order to use //krazy:exclude=<plugin_name>)<br />
** Krazy (the program)<br />
** Krazyall<br />
** Krazyebn<br />
** Plugins<br />
*** General<br />
*** Ideas<br />
**** check for '^\*[[:space:]]*const[[:space:]]' in headers to find stuff like "virtual FolderStorage* const rootFolder() const = 0;" where we'd rather have "virtual FolderStorage* rootFolder() const = 0;" but stuff like "const char * const p" is ok in structures.<br />
*** copyright<br />
**** look in kde-common/accounts to validate name and email address<br />
**** look in an AUTHORS file??<br />
*** spelling<br />
**** provide a list of possible alternatives<br />
**** rewrite the spellchecker to only look at strings and comments in C++ files<br />
*** license<br />
**** Adriaan's updated license checker<br />
**** Look in a COPYRIGHT file?<br />
*** classes<br />
**** there are cases where we want to require ctors and dtors, but it is complicated. (frerich,roberto)<br />
**** Check if all boolean members of a class are initialized in the constructor. See http://thread.gmane.org/gmane.comp.kde.cvs/540002<br />
*** qdisablecopy<br />
****classes with non-pure virtual functions or derived from classes with non-pure virtual functions must have a Q_DISABLE_COPY(). in addition, all the other dpointer requirements are necessary to require Q_DISABLE_COPY().<br />
*** foreach<br />
**** a test that detects using foreach() with objects instead of pointers or const object references, i.e., something that detects "foreach (QModelIndex index, indexes)" (tsdgeos)<br />
*** includes<br />
**** the use of "foo.h" vs. <foo.h><br />
**** if there is an include <kfoo.h>, check for the presence of KFoo:: or KFoo\s+\w or if one class inherits from KFoo. if none found then no need to include that file. (Gof)<br />
**** check if "include <kfoo.h>" would be better as "class KFoo" in a header.<br />
**** consistent about mixing indirect includes <QtCore/QString> and direct includes <qstring.h><br />
**** <QtCore/QString> vs. <QString><br />
*** constmethods<br />
**** check for methods that should be const, i.e methods that return a non-instrinic type and don't modify passed values. a partially working plugin exists in tplugins, but it needs some work<br />
**** check for constness of overloaded operators like ==, !=, <, >, >=, <=, +,-,hat,&,| (christoph4)<br />
*** cast syntax<br />
**** detect the "old cast" syntax: use static_cast<int>(p) instead of (int)p<br />
**** detect useless static_cast: void method(A* p) { x=static_cast<A*>(p);}<br />
*** functions<br />
**** check for reimplementing public-non-virtual-functions<br />
**** check whether reimplemented virtual functions have the same argument list as the function of the base class. Different arguments are probably always error and lead to unwanted results (the wrong virtual functions are called). See commit 672971 as an example. This needs very good support from the C++ parser.<br />
*** connect<br />
**** check whether the signals and slots in a connect() actually exist and match. Although this is also checked at runtime by Qt, rare code paths may still contain errors, especially after all the porting. This needs very good C++ parser support.<br />
*** Blacklist Methods<br />
**** QImage::depth() (fredrikh)<br />
**** calling QApplication::palette() in a class that inherits QWidget is just plain wrong. each widget has its own palette, and it should use that one.<br />
**** don't use the new mixColors() with the background color in the palette<br />
**** Blacklist certain KFoo classes (which ones?) in the public API<br />
*** inline<br />
**** complain for the classes that don't declare a ctor or dtor because that make them inline, implicitly. (Gof)<br />
<br />
== XML Migration plan ==<br />
<br />
Currently bbroeksema is working on xml output for the krazy2 tool. The plan is to slim down krazy2 in such a way that it will only support text output and xml output. The xml output will be transformed, using XSLT style sheets to other outputs like the ebn website html code but also to SQL queries to keep track of historical data.<br />
<br />
First work on style sheets can be found at:<br />
<br />
http://websvn.kde.org:80/trunk/quality/krazy2/stylesheets/<br />
<br />
<br />
=== Migration steps ===<br />
<br />
* Check the XML output of a complete module (e.g. KDEPIM)<br />
* Fix eventually issues in the xml output.<br />
* Check the output of the style sheets which generates the ebn sites.<br />
* Fix eventually issues in the style sheets.<br />
* Make sure that saxon8 is installed on EBN.<br />
* Adapt the script that generates the EBN sites to use XML output (krazy2ebn?)<br />
and to perform the transformations.<br />
* Switch EBN to XML output.<br />
* Remove the other output methods from the krazy2 script.<br />
<br />
Next steps would involve storing all results in the db:<br />
<br />
* Create new database structure on ebn<br />
* Create xml -> sql stylesheet<br />
* Modify the krazy2xml script to store results in db.<br />
* At some point we might want to migrate the ebn website to a full php website which just queries that db.<br />
<br />
== Administration HowTo ==<br />
<br />
=== Finding Component Ids in the DB ===<br />
Look at [http://ebn.kde.org/database.php The EBN Administration page] in the Components table area.<br />
<br />
=== Adding a Component to the DB ===<br />
For example, to add component for KDE SC 4.8:<br />
<pre><br />
% psql -t -h localhost -U kde ebn<br />
ebn=> insert into components values (27,'kde-4.8','KDE SC 4.8','');<br />
ebn=> \quit<br />
</pre><br />
Now reload [http://ebn.kde.org/database.php The EBN Administration page] and you will see the new Id listed in the Components table.<br />
<br />
=== Finding Tool Ids in the DB ===<br />
Look at [http://ebn.kde.org/database.php The EBN Administration page] in the Tools table area.<br />
<br />
=== Adding Tools to the DB ===<br />
You need to add each supported tool to the components of interest. So, to add all our favorite tools to the new kde-4.8 component:<br />
<pre><br />
% psql -t -h localhost -U kde ebn<br />
ebn=> insert into tools values (120,'krazy',27,'Code Checking','','/krazy/',0,'t');<br />
ebn=> insert into tools values (121,'sanitizer',27,'Documentation Sanitizer','','/sanitizer/',0,'t');<br />
ebn=> insert into tools values (122,'dox',27,'API Documentation','','/apidox/',0,'t');<br />
ebn=> \quit<br />
</pre><br />
Now reload [http://ebn.kde.org/database.php The EBN Administration page] and you will see the new Tools listed in the Tools table.<br />
<br />
=== Adding a Checkout for a Component ===<br />
In the quality repo, edit tools/update-checkouts and add a "source_update" line for the new component. For example, to add 4.8:<br />
<pre><br />
source_update $TOP/kde-4.8 "$SC_SVN_MODULES" "branches/KDE/4.8" "4.8"<br />
</pre><br />
Commit the change for update-checkouts.<br />
<br />
The next time the EBN machine does a checkout update (done nightly), the new component will be added to the sources available.<br />
<br />
Or, you can login to the EBN and manually install and run the update, like so:<br />
<pre><br />
% cd /srv/sources/quality<br />
% svn up<br />
% cd tools<br />
% ./install.sh<br />
% ~/bin/update-checkouts<br />
</pre><br />
<br />
== People ==<br />
The EBN is operated by Adriaan de Groot and Allen Winter.<br />
<br />
Authors/Maintainers of the individual quality tools can be found on the [http://www.englishbreakfastnetwork.org/about.php About page].<br />
<br />
== Resources ==</div>Neoclusthttps://techbase.kde.org/index.php?title=User:DarioAndres/ToDo&diff=49047User:DarioAndres/ToDo2010-01-31T00:00:21Z<p>Neoclust: </p>
<hr />
<div>#With STEPS<br />
<br />
216932 --<br />
<br />
<br />
<br />
224028 http://sourceforge.net/projects/subcomposer/ bug report address<br />
<br />
BUGS MARCO MARTIN PLASMA!!!!!!<br />
!!!!!!!!!!!!!!!!!!!!!!!!!!11111!!11<br />
223201<br />
<br />
Close Noatun bug reports @ waiting mail from dev 20100120<br />
<br />
bug 188812 and bug 189279 <br />
<br />
http://kde.pastebin.com/m3322593d<br />
<br />
223949 -- steps<br />
<br />
#Qt issue<br />
https://bugs.kde.org/show_bug.cgi?id=212857<br />
https://bugs.kde.org/show_bug.cgi?id=220853<br />
https://bugs.kde.org/show_bug.cgi?id=218878<br />
https://bugs.kde.org/show_bug.cgi?id=219973<br />
https://bugs.kde.org/show_bug.cgi?id=212618<br />
<br />
221022 otro?<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=220254</s><br />
<br />
https://bugs.kde.org/show_bug.cgi?id=213725<br>https://bugs.kde.org/show_bug.cgi?id=203621<br>https://bugs.kde.org/show_bug.cgi?id=216238<br>217130 -- url<br>https://bugs.kde.org/show_bug.cgi?id=202199 plasma<br>https://bugs.kde.org/show_bug.cgi?id=217358 kopete&nbsp;?<br>https://bugs.kde.org/show_bug.cgi?id=214965<br>https://bugs.kde.org/show_bug.cgi?id=217045<br>https://bugs.kde.org/show_bug.cgi?id=216233<br>https://bugs.kde.org/show_bug.cgi?id=214943<br>https://bugs.kde.org/show_bug.cgi?id=213632<br>https://bugs.kde.org/show_bug.cgi?id=215042 <br />
<br />
#To CHECK<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=218612 - who provides converttopng<br>kopete emesene bugs -&gt; upstream sf&nbsp;?? <br />
<br />
https://bugs.kde.org/show_bug.cgi?id=216357 -- split<br>https://bugs.kde.org/show_bug.cgi?id=207280 -- qt<br>https://bugs.kde.org/show_bug.cgi?id=217591 klocale 4.3.2??<br>https://bugs.kde.org/show_bug.cgi?id=216914 dp https://bugs.kde.org/show_bug.cgi?id=216782<br>https://bugs.kde.org/show_bug.cgi?id=217120 -- downstream<br>https://bugs.kde.org/show_bug.cgi?id=217109 -- qt46 panel height&nbsp;???<br>https://bugs.kde.org/show_bug.cgi?id=216875 --&nbsp;???? phonon xine<br>https://bugs.kde.org/show_bug.cgi?id=216825 -- 199325 similar<br>https://bugs.kde.org/show_bug.cgi?id=216851 dupe 215369<br>https://bugs.kde.org/show_bug.cgi?id=216833 -- reassign bindings<br>https://bugs.kde.org/show_bug.cgi?id=216864 -- proupstream<br>https://bugs.kde.org/show_bug.cgi?id=216516 -- downstream<br>https://bugs.kde.org/show_bug.cgi?id=216641 -- inotify folderview<br>https://bugs.kde.org/show_bug.cgi?id=216661-- check steps<br>https://bugs.kde.org/show_bug.cgi?id=216826 -- reassign plasma<br>https://bugs.kde.org/show_bug.cgi?id=210158 -- qt<br>http://darioandres.pastebin.com/m2defce86 -- maelcum <br />
<br />
208921 look for steps<br> <br />
<br />
KRUNNER DBus issues <br />
<br />
214478 -- upstream <br />
<br />
214267,214136,213076 =&gt; 198421<br>confirmar https://bugs.kde.org/show_bug.cgi?id=212902 <br />
<br />
https://bugs.kde.org/show_bug.cgi?id=209111<br>https://bugs.kde.org/show_bug.cgi?id=192714 --&nbsp;?? <br />
<br />
##UPSTREAM:<br>https://bugs.kde.org/show_bug.cgi?id=211438<br />
<br />
##DEVS<br>https://bugs.kde.org/show_bug.cgi?id=190535 dfaure!!!!!!!!!!!!!!!!!!!!!!!!!!!!<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=208677 -- maksim<br>https://bugs.kde.org/show_bug.cgi?id=210440 -- maksim<br>https://bugs.kde.org/show_bug.cgi?id=193057 -- dfaure dataloss<br>https://bugs.kde.org/show_bug.cgi?id=212342 -- aseigo<br>https://bugs.kde.org/show_bug.cgi?id=196548 -- Remove old code <br />
<br />
https://bugs.kde.org/show_bug.cgi?id=213204 investigate <br />
<br />
211153 new mapping? ask trueg<br>209996 -- MAILSENT##<br>https://bugs.kde.org/show_bug.cgi?id=201686 &lt;- bugzilla html templates thn <br />
<br />
202457 -- check with kompare<br><br />
<br />
<br />
'''OLD'''<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=218220 seems fixed on 4.4<br />
<br />
<br />
----<br />
<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=103790 fixed, new protocol ??</s> Added comment<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=152495 check<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=64754 ??<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=87201 invalid fixed, search dupe?</s> closed<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=194563</s>, New, analizado , mime detection bug OTF = font or OOo Template<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=193579 double check</s> NEW valid<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=193097 double check and fix</s> NEW valid, patch proposed, asked maintainer<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=193045 double check</s> fixed :D<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=192667 upstream-- spell backend?<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=192298 double check</s> could be NEW. asking feedbakc<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=192266 invalid, "sync" api?<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=192227 check<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=191145 patch ksystraycmd<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=191016 new ok, kfilewidget, check code, STRINGFREEZE</s> the code is there, it is not working, bug. dfaure. NEW<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=189994 investigate<br />
<br />
<s> https://bugs.kde.org/show_bug.cgi?id=189338 fixeD?</s> <br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=188523 double check</s> FIXED<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=189207 check</s> NEW, merged, testcase<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=188501 check</s><br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=187943 check</s><br />
<br />
https://bugs.kde.org/show_bug.cgi?id=187606 test?<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=186724 double check<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=185463 test<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=185091 -- old- retest-- ask feedback<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=184087 -- check - easy fix</s> patch proposed, asking feedback<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=183800 - check and search fix<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=182384 -- check and commit fix<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=182239 recheck... weirrrrd<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=181607 check!!! EASY check</s> This is NEW<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=181362 application specific ? KRun , invokeBrowser ?? check<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=180964 kfileplaces bug?<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=180289 check</s> A fix at KFileWidget could be tried.<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=179554 check</s> WFM<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=179032 check and fix<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=177552 check<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=176766 check<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=171562 ask dfaure about proposed patch<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=170177 check</s> WFM asking feedback<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=169231 check ?<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=169212 check<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=168333 close as invalid.. recheck?<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=164300 recheck<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=165210 check and review highlighter code<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=159331 check.. I think it is fixed<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=156678<br />
<br />
sorting bugs:<br />
https://bugs.kde.org/show_bug.cgi?id=160282<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=190919<br />
<br />
has related everywhere:<br />
https://bugs.kde.org/show_bug.cgi?id=157293<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=156313 look for fix<br />
<br />
<br />
* {{Bug|51507}} Can't reproduce - using a KSqueezedtextlabel {{Bug|62736}}<br />
* {{Bug|52741}} Not a bug?<br />
* {{Bug|62736}} (comment 7) Fixed too- uses KSqueezedTextLabel<br />
* {{Bug|65692}} is "AutoFS" deprecated/old ?<br />
* {{Bug|66281}} Can't reproduce. (needs to file a Plasma bug...)<br />
* {{Bug|69569}} Deprecated slaves (print:/ system:/) , settings:/ works<br />
* <s>{{Bug|75248}} Can't reproduce - OpenWith/Other dialog isn't expanded when having a long entry.</s> WFM [[User:Blauzahl|Blauzahl]]<br />
* <s>{{Bug|162392}}</s> WFM [[User:Blauzahl|Blauzahl]]<br />
* {{Bug|169798}} svg. blah. valid.<br />
* {{Bug|155656}} mc. devs use this, i'm surprised nobody has noticed [[User:Blauzahl|Blauzahl]]<br />
* {{Bug|70986}} I can't reproduce<br />
* {{Bug|158446}} Works for me... tested with Oxygen svgz icons<br />
* {{Bug|158449}} I can't reproduce exactly. however it seems to be an error with minimum size of the filedialog<br />
* {{Bug|111113}} seems fixed<br />
* {{Bug|104759}} seems fixed<br />
<s>* {{Bug|184408}} proposed patch to be reviewed..</s><br />
* {{Bug|154655}} I can't reproduce crash. works ok<br />
* {{Bug|180007}} I can't reproduce crash. works ok<br />
* {{Bug|182552}} I can't reproduce crash. works ok<br />
* {{Bug|146303}} I can't reproduce crash.<br />
* {{Bug|95488}} Works for me.. doesn't crash.<br />
* {{Bug|52938}} Provided testcase, works for me, qsliders on toolbar styled properly.<br />
* {{Bug|118493}} Works for me now<br />
* {{Bug|56118}} Works for me<br />
* {{Bug|193579}} WFM<br />
* {{Bug|166888}} WFM<br />
* {{Bug|62778}} WFM<br />
* {{Bug|54606}} WFM<br />
* {{Bug|58950}} WFM<br />
* {{Bug|69024}} Upstream Qt wish/feature?<br />
* {{Bug|69462}} New</div>Neoclusthttps://techbase.kde.org/index.php?title=User:DarioAndres/ToDo&diff=49046User:DarioAndres/ToDo2010-01-30T23:55:38Z<p>Neoclust: </p>
<hr />
<div>#With STEPS<br />
<br />
216932 --<br />
<br />
<br />
<br />
224028 http://sourceforge.net/projects/subcomposer/ bug report address<br />
<br />
BUGS MARCO MARTIN PLASMA!!!!!!<br />
!!!!!!!!!!!!!!!!!!!!!!!!!!11111!!11<br />
223201<br />
<br />
Close Noatun bug reports @ waiting mail from dev 20100120<br />
<br />
bug 188812 and bug 189279 <br />
<br />
http://kde.pastebin.com/m3322593d<br />
<br />
223949 -- steps<br />
<br />
#Qt issue<br />
https://bugs.kde.org/show_bug.cgi?id=212857<br />
https://bugs.kde.org/show_bug.cgi?id=220853<br />
https://bugs.kde.org/show_bug.cgi?id=218878<br />
https://bugs.kde.org/show_bug.cgi?id=219973<br />
https://bugs.kde.org/show_bug.cgi?id=212618<br />
<br />
221022 otro?<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=220254</s><br />
<br />
https://bugs.kde.org/show_bug.cgi?id=213725<br>https://bugs.kde.org/show_bug.cgi?id=203621<br>https://bugs.kde.org/show_bug.cgi?id=216238<br>217130 -- url<br>https://bugs.kde.org/show_bug.cgi?id=202199 plasma<br>https://bugs.kde.org/show_bug.cgi?id=217358 kopete&nbsp;?<br>https://bugs.kde.org/show_bug.cgi?id=214965<br>https://bugs.kde.org/show_bug.cgi?id=217045<br>https://bugs.kde.org/show_bug.cgi?id=216233<br>https://bugs.kde.org/show_bug.cgi?id=214943<br>https://bugs.kde.org/show_bug.cgi?id=213632<br>https://bugs.kde.org/show_bug.cgi?id=215042 <br />
<br />
#To CHECK<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=218612 - who provides converttopng<br>kopete emesene bugs -&gt; upstream sf&nbsp;?? <br />
<br />
https://bugs.kde.org/show_bug.cgi?id=216357 -- split<br>https://bugs.kde.org/show_bug.cgi?id=207280 -- qt<br>https://bugs.kde.org/show_bug.cgi?id=217591 klocale 4.3.2??<br>https://bugs.kde.org/show_bug.cgi?id=216914 dp https://bugs.kde.org/show_bug.cgi?id=216782<br>https://bugs.kde.org/show_bug.cgi?id=217120 -- downstream<br>https://bugs.kde.org/show_bug.cgi?id=217109 -- qt46 panel height&nbsp;???<br>https://bugs.kde.org/show_bug.cgi?id=216875 --&nbsp;???? phonon xine<br>https://bugs.kde.org/show_bug.cgi?id=216825 -- 199325 similar<br>https://bugs.kde.org/show_bug.cgi?id=216851 dupe 215369<br>https://bugs.kde.org/show_bug.cgi?id=216833 -- reassign bindings<br>https://bugs.kde.org/show_bug.cgi?id=216864 -- proupstream<br>https://bugs.kde.org/show_bug.cgi?id=216516 -- downstream<br>https://bugs.kde.org/show_bug.cgi?id=216641 -- inotify folderview<br>https://bugs.kde.org/show_bug.cgi?id=216661-- check steps<br>https://bugs.kde.org/show_bug.cgi?id=216826 -- reassign plasma<br>https://bugs.kde.org/show_bug.cgi?id=210158 -- qt<br>http://darioandres.pastebin.com/m2defce86 -- maelcum <br />
<br />
208921 look for steps<br> <br />
<br />
KRUNNER DBus issues <br />
<br />
214478 -- upstream <br />
<br />
214267,214136,213076 =&gt; 198421<br>confirmar https://bugs.kde.org/show_bug.cgi?id=212902 <br />
<br />
https://bugs.kde.org/show_bug.cgi?id=209111<br>https://bugs.kde.org/show_bug.cgi?id=192714 --&nbsp;?? <br />
<br />
##UPSTREAM:<br>https://bugs.kde.org/show_bug.cgi?id=211438<br />
<br />
##DEVS<br>https://bugs.kde.org/show_bug.cgi?id=190535 dfaure!!!!!!!!!!!!!!!!!!!!!!!!!!!!<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=208677 -- maksim<br>https://bugs.kde.org/show_bug.cgi?id=210440 -- maksim<br>https://bugs.kde.org/show_bug.cgi?id=193057 -- dfaure dataloss<br>https://bugs.kde.org/show_bug.cgi?id=212342 -- aseigo<br>https://bugs.kde.org/show_bug.cgi?id=196548 -- Remove old code <br />
<br />
https://bugs.kde.org/show_bug.cgi?id=213204 investigate <br />
<br />
211153 new mapping? ask trueg<br>209996 -- MAILSENT##<br>https://bugs.kde.org/show_bug.cgi?id=201686 &lt;- bugzilla html templates thn <br />
<br />
202457 -- check with kompare<br><br />
<br />
<br />
'''OLD'''<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=218220 seems fixed on 4.4<br />
<br />
<br />
----<br />
<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=103790 fixed, new protocol ??</s> Added comment<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=152495 check<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=64754 ??<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=87201 invalid fixed, search dupe?</s> closed<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=194563</s>, New, analizado , mime detection bug OTF = font or OOo Template<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=193579 double check</s> NEW valid<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=193097 double check and fix</s> NEW valid, patch proposed, asked maintainer<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=193045 double check</s> fixed :D<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=192667 upstream-- spell backend?<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=192298 double check</s> could be NEW. asking feedbakc<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=192266 invalid, "sync" api?<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=192227 check<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=191145 patch ksystraycmd<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=191016 new ok, kfilewidget, check code, STRINGFREEZE</s> the code is there, it is not working, bug. dfaure. NEW<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=189994 investigate<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=189338 fixeD?<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=188523 double check</s> FIXED<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=189207 check</s> NEW, merged, testcase<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=188501 check</s><br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=187943 check</s><br />
<br />
https://bugs.kde.org/show_bug.cgi?id=187606 test?<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=186724 double check<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=185463 test<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=185091 -- old- retest-- ask feedback<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=184087 -- check - easy fix</s> patch proposed, asking feedback<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=183800 - check and search fix<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=182384 -- check and commit fix<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=182239 recheck... weirrrrd<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=181607 check!!! EASY check</s> This is NEW<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=181362 application specific ? KRun , invokeBrowser ?? check<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=180964 kfileplaces bug?<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=180289 check</s> A fix at KFileWidget could be tried.<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=179554 check</s> WFM<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=179032 check and fix<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=177552 check<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=176766 check<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=171562 ask dfaure about proposed patch<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=170177 check</s> WFM asking feedback<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=169231 check ?<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=169212 check<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=168333 close as invalid.. recheck?<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=164300 recheck<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=165210 check and review highlighter code<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=159331 check.. I think it is fixed<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=156678<br />
<br />
sorting bugs:<br />
https://bugs.kde.org/show_bug.cgi?id=160282<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=190919<br />
<br />
has related everywhere:<br />
https://bugs.kde.org/show_bug.cgi?id=157293<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=156313 look for fix<br />
<br />
<br />
* {{Bug|51507}} Can't reproduce - using a KSqueezedtextlabel {{Bug|62736}}<br />
* {{Bug|52741}} Not a bug?<br />
* {{Bug|62736}} (comment 7) Fixed too- uses KSqueezedTextLabel<br />
* {{Bug|65692}} is "AutoFS" deprecated/old ?<br />
* {{Bug|66281}} Can't reproduce. (needs to file a Plasma bug...)<br />
* {{Bug|69569}} Deprecated slaves (print:/ system:/) , settings:/ works<br />
* <s>{{Bug|75248}} Can't reproduce - OpenWith/Other dialog isn't expanded when having a long entry.</s> WFM [[User:Blauzahl|Blauzahl]]<br />
* <s>{{Bug|162392}}</s> WFM [[User:Blauzahl|Blauzahl]]<br />
* {{Bug|169798}} svg. blah. valid.<br />
* {{Bug|155656}} mc. devs use this, i'm surprised nobody has noticed [[User:Blauzahl|Blauzahl]]<br />
* {{Bug|70986}} I can't reproduce<br />
* {{Bug|158446}} Works for me... tested with Oxygen svgz icons<br />
* {{Bug|158449}} I can't reproduce exactly. however it seems to be an error with minimum size of the filedialog<br />
* {{Bug|111113}} seems fixed<br />
* {{Bug|104759}} seems fixed<br />
<s>* {{Bug|184408}} proposed patch to be reviewed..</s><br />
* {{Bug|154655}} I can't reproduce crash. works ok<br />
* {{Bug|180007}} I can't reproduce crash. works ok<br />
* {{Bug|182552}} I can't reproduce crash. works ok<br />
* {{Bug|146303}} I can't reproduce crash.<br />
* {{Bug|95488}} Works for me.. doesn't crash.<br />
* {{Bug|52938}} Provided testcase, works for me, qsliders on toolbar styled properly.<br />
* {{Bug|118493}} Works for me now<br />
* {{Bug|56118}} Works for me<br />
* {{Bug|193579}} WFM<br />
* {{Bug|166888}} WFM<br />
* {{Bug|62778}} WFM<br />
* {{Bug|54606}} WFM<br />
* {{Bug|58950}} WFM<br />
* {{Bug|69024}} Upstream Qt wish/feature?<br />
* {{Bug|69462}} New</div>Neoclusthttps://techbase.kde.org/index.php?title=User:DarioAndres/ToDo&diff=49044User:DarioAndres/ToDo2010-01-30T23:52:23Z<p>Neoclust: </p>
<hr />
<div>#With STEPS<br />
<br />
216932 --<br />
<br />
<br />
<br />
224028 http://sourceforge.net/projects/subcomposer/ bug report address<br />
<br />
BUGS MARCO MARTIN PLASMA!!!!!!<br />
!!!!!!!!!!!!!!!!!!!!!!!!!!11111!!11<br />
223201<br />
<br />
Close Noatun bug reports @ waiting mail from dev 20100120<br />
<br />
bug 188812 and bug 189279 <br />
<br />
http://kde.pastebin.com/m3322593d<br />
<br />
223949 -- steps<br />
<br />
#Qt issue<br />
https://bugs.kde.org/show_bug.cgi?id=212857<br />
https://bugs.kde.org/show_bug.cgi?id=220853<br />
https://bugs.kde.org/show_bug.cgi?id=218878<br />
https://bugs.kde.org/show_bug.cgi?id=219973<br />
https://bugs.kde.org/show_bug.cgi?id=212618<br />
<br />
221022 otro?<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=220254<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=213725<br>https://bugs.kde.org/show_bug.cgi?id=203621<br>https://bugs.kde.org/show_bug.cgi?id=216238<br>217130 -- url<br>https://bugs.kde.org/show_bug.cgi?id=202199 plasma<br>https://bugs.kde.org/show_bug.cgi?id=217358 kopete&nbsp;?<br>https://bugs.kde.org/show_bug.cgi?id=214965<br>https://bugs.kde.org/show_bug.cgi?id=217045<br>https://bugs.kde.org/show_bug.cgi?id=216233<br>https://bugs.kde.org/show_bug.cgi?id=214943<br>https://bugs.kde.org/show_bug.cgi?id=213632<br>https://bugs.kde.org/show_bug.cgi?id=215042 <br />
<br />
#To CHECK<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=218612 - who provides converttopng<br>kopete emesene bugs -&gt; upstream sf&nbsp;?? <br />
<br />
https://bugs.kde.org/show_bug.cgi?id=216357 -- split<br>https://bugs.kde.org/show_bug.cgi?id=207280 -- qt<br>https://bugs.kde.org/show_bug.cgi?id=217591 klocale 4.3.2??<br>https://bugs.kde.org/show_bug.cgi?id=216914 dp https://bugs.kde.org/show_bug.cgi?id=216782<br>https://bugs.kde.org/show_bug.cgi?id=217120 -- downstream<br>https://bugs.kde.org/show_bug.cgi?id=217109 -- qt46 panel height&nbsp;???<br>https://bugs.kde.org/show_bug.cgi?id=216875 --&nbsp;???? phonon xine<br>https://bugs.kde.org/show_bug.cgi?id=216825 -- 199325 similar<br>https://bugs.kde.org/show_bug.cgi?id=216851 dupe 215369<br>https://bugs.kde.org/show_bug.cgi?id=216833 -- reassign bindings<br>https://bugs.kde.org/show_bug.cgi?id=216864 -- proupstream<br>https://bugs.kde.org/show_bug.cgi?id=216516 -- downstream<br>https://bugs.kde.org/show_bug.cgi?id=216641 -- inotify folderview<br>https://bugs.kde.org/show_bug.cgi?id=216661-- check steps<br>https://bugs.kde.org/show_bug.cgi?id=216826 -- reassign plasma<br>https://bugs.kde.org/show_bug.cgi?id=210158 -- qt<br>http://darioandres.pastebin.com/m2defce86 -- maelcum <br />
<br />
208921 look for steps<br> <br />
<br />
KRUNNER DBus issues <br />
<br />
214478 -- upstream <br />
<br />
214267,214136,213076 =&gt; 198421<br>confirmar https://bugs.kde.org/show_bug.cgi?id=212902 <br />
<br />
https://bugs.kde.org/show_bug.cgi?id=209111<br>https://bugs.kde.org/show_bug.cgi?id=192714 --&nbsp;?? <br />
<br />
##UPSTREAM:<br>https://bugs.kde.org/show_bug.cgi?id=211438<br />
<br />
##DEVS<br>https://bugs.kde.org/show_bug.cgi?id=190535 dfaure!!!!!!!!!!!!!!!!!!!!!!!!!!!!<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=208677 -- maksim<br>https://bugs.kde.org/show_bug.cgi?id=210440 -- maksim<br>https://bugs.kde.org/show_bug.cgi?id=193057 -- dfaure dataloss<br>https://bugs.kde.org/show_bug.cgi?id=212342 -- aseigo<br>https://bugs.kde.org/show_bug.cgi?id=196548 -- Remove old code <br />
<br />
https://bugs.kde.org/show_bug.cgi?id=213204 investigate <br />
<br />
211153 new mapping? ask trueg<br>209996 -- MAILSENT##<br>https://bugs.kde.org/show_bug.cgi?id=201686 &lt;- bugzilla html templates thn <br />
<br />
202457 -- check with kompare<br><br />
<br />
<br />
'''OLD'''<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=218220 seems fixed on 4.4<br />
<br />
<br />
----<br />
<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=103790 fixed, new protocol ??</s> Added comment<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=152495 check<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=64754 ??<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=87201 invalid fixed, search dupe?</s> closed<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=194563</s>, New, analizado , mime detection bug OTF = font or OOo Template<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=193579 double check</s> NEW valid<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=193097 double check and fix</s> NEW valid, patch proposed, asked maintainer<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=193045 double check</s> fixed :D<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=192667 upstream-- spell backend?<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=192298 double check</s> could be NEW. asking feedbakc<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=192266 invalid, "sync" api?<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=192227 check<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=191145 patch ksystraycmd<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=191016 new ok, kfilewidget, check code, STRINGFREEZE</s> the code is there, it is not working, bug. dfaure. NEW<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=189994 investigate<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=189338 fixeD?<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=188523 double check</s> FIXED<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=189207 check</s> NEW, merged, testcase<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=188501 check</s><br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=187943 check</s><br />
<br />
https://bugs.kde.org/show_bug.cgi?id=187606 test?<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=186724 double check<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=185463 test<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=185091 -- old- retest-- ask feedback<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=184087 -- check - easy fix</s> patch proposed, asking feedback<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=183800 - check and search fix<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=182384 -- check and commit fix<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=182239 recheck... weirrrrd<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=181607 check!!! EASY check</s> This is NEW<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=181362 application specific ? KRun , invokeBrowser ?? check<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=180964 kfileplaces bug?<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=180289 check</s> A fix at KFileWidget could be tried.<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=179554 check</s> WFM<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=179032 check and fix<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=177552 check<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=176766 check<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=171562 ask dfaure about proposed patch<br />
<br />
<s>https://bugs.kde.org/show_bug.cgi?id=170177 check</s> WFM asking feedback<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=169231 check ?<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=169212 check<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=168333 close as invalid.. recheck?<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=164300 recheck<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=165210 check and review highlighter code<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=159331 check.. I think it is fixed<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=156678<br />
<br />
sorting bugs:<br />
https://bugs.kde.org/show_bug.cgi?id=160282<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=190919<br />
<br />
has related everywhere:<br />
https://bugs.kde.org/show_bug.cgi?id=157293<br />
<br />
https://bugs.kde.org/show_bug.cgi?id=156313 look for fix<br />
<br />
<br />
* {{Bug|51507}} Can't reproduce - using a KSqueezedtextlabel {{Bug|62736}}<br />
* {{Bug|52741}} Not a bug?<br />
* {{Bug|62736}} (comment 7) Fixed too- uses KSqueezedTextLabel<br />
* {{Bug|65692}} is "AutoFS" deprecated/old ?<br />
* {{Bug|66281}} Can't reproduce. (needs to file a Plasma bug...)<br />
* {{Bug|69569}} Deprecated slaves (print:/ system:/) , settings:/ works<br />
* <s>{{Bug|75248}} Can't reproduce - OpenWith/Other dialog isn't expanded when having a long entry.</s> WFM [[User:Blauzahl|Blauzahl]]<br />
* <s>{{Bug|162392}}</s> WFM [[User:Blauzahl|Blauzahl]]<br />
* {{Bug|169798}} svg. blah. valid.<br />
* {{Bug|155656}} mc. devs use this, i'm surprised nobody has noticed [[User:Blauzahl|Blauzahl]]<br />
* {{Bug|70986}} I can't reproduce<br />
* {{Bug|158446}} Works for me... tested with Oxygen svgz icons<br />
* {{Bug|158449}} I can't reproduce exactly. however it seems to be an error with minimum size of the filedialog<br />
* {{Bug|111113}} seems fixed<br />
* {{Bug|104759}} seems fixed<br />
<s>* {{Bug|184408}} proposed patch to be reviewed..</s><br />
* {{Bug|154655}} I can't reproduce crash. works ok<br />
* {{Bug|180007}} I can't reproduce crash. works ok<br />
* {{Bug|182552}} I can't reproduce crash. works ok<br />
* {{Bug|146303}} I can't reproduce crash.<br />
* {{Bug|95488}} Works for me.. doesn't crash.<br />
* {{Bug|52938}} Provided testcase, works for me, qsliders on toolbar styled properly.<br />
* {{Bug|118493}} Works for me now<br />
* {{Bug|56118}} Works for me<br />
* {{Bug|193579}} WFM<br />
* {{Bug|166888}} WFM<br />
* {{Bug|62778}} WFM<br />
* {{Bug|54606}} WFM<br />
* {{Bug|58950}} WFM<br />
* {{Bug|69024}} Upstream Qt wish/feature?<br />
* {{Bug|69462}} New</div>Neoclusthttps://techbase.kde.org/index.php?title=Contribute/Send_Patches&diff=48863Contribute/Send Patches2010-01-23T20:58:20Z<p>Neoclust: </p>
<hr />
<div>{{Template:I18n/Language Navigation Bar|Contribute/Send Patches}}<br />
This tutorial shows how to send modifications of code in the right way: '''by using patches'''.<br />
<br />
== Notation ==<br />
<br />
The word ''developer'' is used here for someone having a KDE SVN account.<br />
<br />
== Preliminaries ==<br />
<br />
We suppose that you have modified some code in KDE and that you are ready to share it. First a few important points:<br />
* You must allow that the modification will have the license of the file where the modification is made.<br />
* Please make sure that the code compiles correctly on a (fairly) recent version of the software.<br />
<br />
== What Is a Patch? ==<br />
<br />
Now you have the modification as a source file. Sending the source file will not be helpful, as probably someone else has done other modifications to the original file in the meantime. So your modified file could not replace it.<br />
<br />
That is why patches exist. Patches list the modifications, the line numbers and a few other useful information to be able to put that patch back into the existing code. (This process is called "patching" or also "applying a patch.")<br />
<br />
The main tool for creating patches is a tool called '''diff''', which makes the difference between two files. This tool has a mode called ''unified diff'', which KDE developers use. Unified diffs have not just the difference between the file but also the ''neighborhood'' around the differences. That allows to patch even if the line numbers are not the same anymore.<br />
<br />
== Creating a Simple File Patch ==<br />
<br />
The most simple patch is created between the modified file (here called {{path|source.cpp}}) and the non-modified version of the file (here called {{path|source.cpp.orig}}.)<br />
diff -u -p source.cpp.orig source.cpp<br />
<br />
That lists the difference between the two files in the unified diff format (and with function name information if possible.) However it only displays it to screen, which is of course not the goal. So you need to redirect the output.<br />
diff -u -p source.cpp.orig source.cpp &gt; ~/patch.diff<br />
<br />
{{path|~/patch.diff}} is here an example and you can create the file where you prefer with the name that you prefer. (You will soon find out that it is probably not a good idea to create a patch where the source is.)<br />
<br />
== The More Common Case ==<br />
<br />
But normally, you do not just change one file and you do not keep the original version around to be able to make the difference later. But here too, there is a solution.<br />
<br />
The program svn, which is used on the command line interact with the SVN server, has a diff function too: '''svn diff'''.<br />
<br />
You can run it like this and it will give you the difference of the current directory and all sub-directories below it. Of course, here too, you want to redirect the output.<br />
<br />
svn diff &gt; ~/patch.diff<br />
<br />
There are useful variants too (shown here without redirection)<br />
* For just one file: '''svn diff source.cpp'''<br />
* For the current directory only: '''svn diff -N'''<br />
<br />
'''Note''': even if svn can make the difference of another directory (svn diff mydirectory), it is not recommended to do it for a patch that should be applied again. (The problem is that the person that will apply the patch will have to be more careful about how he applies it.)<br />
<br />
'''Note''': for simple diff, like those shown in the examples above, '''svn diff''' can be used offline, therefore without an active connection to the KDE SVN server. This is possible, as svn keeps a copy of the original files locally. (This feature is part of the design of SVN.)<br />
<br />
By default, svn diff does not have a feature like the <tt>-p</tt> parameter of diff. But svn allows that an external diff program is called, so you can call diff:<br />
svn diff --diff-cmd diff --extensions "-u -p"<br />
<br />
== Non-Text Files ==<br />
<br />
The procedures described above work very well with text files, for example C++ source code. However they do not work with binary files, as diff is not made to handle them. And even if SVN can internally store binary differences, svn diff is not prepared to do anything similar yet, mainly because it currently uses the unified diff format only, which is not meant for binary data.<br />
<br />
Therefore, unfortunately, there is little choice but to attach binary files separately from the patch, of course attached in the same email.<br />
<br />
== New Files ==<br />
<br />
First, you need to make svn aware of files you have added.<br />
svn add path/to/new/file /path/to/another/new/file<br />
<br />
Then run '''svn diff''' as before.<br />
<br />
Note that if you do '''svn revert''', for example, the files you created will NOT be deleted by svn - but svn will no longer care about them (so they won't show up when you do '''svn diff''', for example). You will have to '''rm''' them manually.<br />
<br />
(TODO: are there any other issues with adding new files if you don't have commit access?)<br />
<br />
== How To Share the Patch? ==<br />
<br />
Now you are ready to share the patch. If your patch fixes a bug from [http://bugs.kde.org KDE Bugs], then the easiest way is to attach it there, see next section.<br />
<br />
The main way of sharing a patch is to email to a mailing list. But be careful not to send big patches to a mailing list, a few 10KB is the limit.<br />
<br />
Some projects use [http://reviewboard.kde.org KDE's reviewboard] for patch submitting. If a project is using the reviewboard, that is usually their preffered way of receiving patches. See the [[Contribute/Send_Patches#Reviewboard|section below]] for details.<br />
<br />
If you find that the patch is too big to send to a mailing list, the best is to create a bug report in [http://bugs.kde.org KDE Bugs] and to attach the patch there, after having created the bug report.<br />
<br />
Another possibility, however seldom used, is to post the patch on a public Web server (be it by HTTP or FTP) and to send an email to the mailing list, telling that the patch is waiting there.<br />
<br />
Another variant is to ask on the mailing list which developer is ready to get a big patch. (Try to give its size and ask if you should send it compressed, for example by bzip2.)<br />
<br />
A last variant, if you know exactly which developer will process the patch and that you know or that you suppose that he currently has time, is to send the patch to a developer directly. (But here too, be careful if your patch is big. Some KDE developers still have analog modems.)<br />
<br />
=== Patches for KDE Bugs ===<br />
<br />
In this section we assume that you have chosen to add your patch to an existing KDE bug or that you have created a bug report just for your patch.<br />
<br />
Even if this tutorial is more meant to send patches to a mailing list, most of it can be applied to adding a patch to [http://bugs.kde.org KDE Bugs].<br />
<br />
You have two ways to do it:<br />
* online, by selecting the bug report and using the web interface to add attachments.<br />
* offline, by emailing to the bug report.<br />
<br />
To send an email to a bug report, you can use an email address of the form '''12345@bugs.kde.org''' where 12345 is the bug number. Please be sure to attach your patch and not to have it inlined in your text. (If it is inlined, it would be corrupted by KDE Bugs, as HTML does not respect spaces.)<br />
<br />
'''Note''': if you send an email to KDE Bugs, be careful to use as sender the same email address as your login email address in KDE Bugs. Otherwise KDE Bugs will reject your email.<br />
<br />
'''Note''': if you create a new bug report just for your patch, be careful that you cannot attach a patch directly when creating a new bug. However as soon as the new bug is created, you can then attach files, one-by-one, therefore also patches.<br />
<br />
'''Warning''': sometimes your patch will be forgotten because the developers do not always closely monitor the bug database. In this case, try sending your patch by email as described below. If that also does not help, you can always talk to the developers on [[Development/Further_Information#IRC_Channels|IRC]]<br />
<br />
=== Which Mailing List? ===<br />
<br />
Assuming that you have chosen to send the patch to a mailing list, you might ask yourself: to which one?<br />
<br />
The best destination for patches is the [http://www.kde.org/mailinglists corresponding developer mailing list].<br />
<br />
In case of doubt, you can send any patch for KDE to the [mailto:kde-devel@kde.org kde-devel mailing list]. (However with an increased risk that you would miss the right developer.)<br />
<br />
Of course, if you know exactly which developer will process the patch and that you know or that you suppose that he currently has time, then you can send the patch to him directly.<br />
<br />
=== Preparing The Email ===<br />
<br />
Now you have a patch redirected into a file (for this example called patch.diff), you are ready to send it by email. But the first question: where?<br />
<br />
Now that you have entered an email address, a good practice is to attach the patch to your file before writing anything else in the email. So you will not forget to attach it.<br />
<br />
A little note here: yes, in KDE (unlike for the Linux Kernel for example), we prefer to have the patches sent as attachments.<br />
<br />
Now you are ready to write the rest of the email. Please think of a title that matches your patch. (Think of having to find it again in [http://lists.kde.org the archives] in a few months or even years.) A good habit is to precede the title by <nowiki>[PATCH]</nowiki>. So for example a title could be <nowiki>[PATCH] Fix backup files</nowiki>.<br />
<br />
As for the body of the email, please tell to which file or directory your patch applies. For example for a file:<br />
''The attached patch applies to the file koffice/kword/kwdoc.cpp'' or for a directory: ''The attached patch applies to the directory koffice/kword''. This help the developers to have an overview of which code has been modified. Also tell for which branch it is meant, for example for trunk.<br />
<br />
Then tell what your patch does. If it fixes a bug, then please give the bug number too. If the bug was not registered in [http://bugs.kde.org KDE Bugs], then please describe instead the bug that is fixed. Similarly, if you know that the patch fixes a bug introduced from a precise SVN revision, please add the revision number.<br />
<br />
Tell also what could be useful to the developers, for example if you could not completely test the patch (and why), if you need help to finish fixing the code or if it is a quick&dirty solution that should be fixed better in long-term.<br />
<br />
Now check the email again to see if you have not forgotten anything (especially to attach the patch) and you can send the email.<br />
<br />
=== Reviewboard ===<br />
<br />
One popular way of submitting patches is [http://reviewboard.kde.org KDE's reviewboard]. A big advantage over using the bugtracker of KDE is that the patches are less likely to be forgotten here. Also, the reviewboard allows inline review of diffs and other gimmicks.<br />
<br />
First you need to check if the project you've created the patch for is actually using reviewboard. For this, go to the [http://reviewboard.kde.org/groups/ groups section] and see if the project's group is listed there. If it is listed there, you should use the reviewboard, otherwise send the patch by other means.<br />
<br />
For sending a patch, you first need to register. Then simply click ''[http://reviewboard.kde.org/r/new/ New Review Request]'' and fill out the form. The most important parts of the form are:<br />
<br />
* '''The actual patch'''. You need to upload the patch you've created earlier here<br />
* '''The SVN base path'''. This is needed for the inline patch display to work. This can be a bit tricky, if you are unfamiliar with KDE's SVN layout, check [http://websvn.kde.org WebSVN]. For example, if you're ''svn diff'ing'' from <tt>/path/to/your/copy/of/kdelibs/cmake/modules</tt>, the base path should be <tt>/trunk/KDE/kdelibs/cmake/modules</tt>. If you still don't know the correct base path, ask a developer on IRC. You can also edit the review request later.<br />
* '''A summary of the patch'''. This should be short, it will show up as subject of the notification emails.<br />
* '''A description of the patch'''. This can be longer.<br />
* '''The group(s)'''. Make sure you enter the correct group '''ID''' here, as seen earlier on the [http://reviewboard.kde.org/groups/ groups page].<br />
<br />
After you completed the form, a notification mail will be sent to the developers and they will answer you.<br />
<br />
/!\ You need to use svn diff in english, if your system is not english, please do LC_ALL=C svn diff<br />
<br />
=== And Now? ===<br />
<br />
Now you have to wait that a developer reacts on your patch. (If you are not subscribed to the mailing lists where you have sent the patch, then monitor [http://lists.kde.org the mailing list archives]] for such a message.)<br />
<br />
The reaction is normally one of the following:<br />
* No developer answers. (That is unfortunately happening from time to time.)<br />
* The developer does not want your patch, as he is working on the same code.<br />
* The developer does not like your patch.<br />
* The developer finds that you should change a few things.<br />
* The developer finds the patch good and tells that he will work on it.<br />
* The developer accepts your patch as it is.<br />
<br />
The first case is when nobody has answered. That perhaps means that you have chosen the wrong mailing list. Perhaps you have not explained correctly what the patch fixes or you have given a title that is not precise enough. If this happens, the developer might have overlooked the patch. Perhaps the developer that should have answered has not any time currently. (That too happens unfortunately.) The best is to try to work a little more on the patch, make a better description and try again a second time, perhaps to another mailing list or to use [http://bugs.kde.org KDE Bugs] instead.<br />
<br />
If the developer tells you that your patch conflicts with changes that he is currently doing, you could probably not do much against it. Maybe you can discuss with him how you can effectively work with him on this piece of code.<br />
<br />
If your patch was not accepted, you could work further on it. Probably you should discuss the problem on the mailing list to know in which direction you should work further.<br />
<br />
If a developer wants a few changes, then work on the code to make the changes according to the critic. If you need help because you do not understand how to do the needed change, then ask it on the mailing list.<br />
<br />
If your patch was accepted, congratulations! :)</div>Neoclust