Policies/CMake Commit Policy - Revision history

Nicolas17: Replace underscores with spaces in page links

2010-07-31T02:38:09Z

Replace underscores with spaces in page links

Nicolas17: grammar fix

2010-07-31T02:37:10Z

grammar fix

Tampakrap at 16:57, 4 October 2009

2009-10-04T16:57:45Z

Neundorf at 17:59, 29 March 2009

2009-03-29T17:59:03Z

Neundorf at 16:42, 29 March 2009

2009-03-29T16:42:56Z

Neundorf at 16:37, 29 March 2009

2009-03-29T16:37:35Z

Neundorf: New page: The files located in kdelibs/cmake/modules/ are installed and can be used by other application. This means they are part of the public interface of kdelibs and we have to keep compatibil...

2009-03-29T16:33:23Z

New page: The files located in kdelibs/cmake/modules/ are installed and can be used by other application. This means they are part of the public interface of kdelibs and we have to keep compatibil...

New page

The files located in kdelibs/cmake/modules/ are installed and can be used by other application.
This means they are part of the public interface of kdelibs and we have to
keep compatibility. Committing there also has the potential to break the
build of whole KDE for everybody.

When committing changes thereHere is the proposal for a commit policy for kdelibs/cmake/modules/ :

# Adding new files: new files must be sent to kde-buildsystem@kde.org for review. They may only be added after an explicit ok.
# Patches which change how something is done in general for many files must be posted first. They may only be committed after an explicit ok.
# Adding public macros or functions: they must be posted for review first. If there is NO answer at all within two weeks they may be committed anyway.
# Documentation must never be removed as long as it is valid and not replaced.
# Other patches can always be committed.
# All patches must maintain source compatibility.

@@ Line 10: / Line 10: @@
 # Documentation must never be removed as long as it is valid and not replaced.
 # Other patches can always be committed without review.
-# All patches must maintain [[Policies/CMake_and_Source_Compatibility|source compatibility]].
+# All patches must maintain [[Policies/CMake and Source Compatibility|source compatibility]].
-# All patches must follow the [[Policies/CMake_Coding_Style|coding style]] for CMake files in KDE.
+# All patches must follow the [[Policies/CMake Coding Style|coding style]] for CMake files in KDE.

@@ Line 1: / Line 1: @@
 The policies outlined here apply to the CMake files in kdelibs/cmake/modules/, i.e. they don't apply to CMake files in other KDE modules.
-The files located in kdelibs/cmake/modules/ are installed and can be used by other application. This means they are part of the public interface of kdelibs and we have to keep compatibility. Committing there also has the potential to break the build of whole KDE for everybody.
+The files located in kdelibs/cmake/modules/ are installed and can be used by other applications. This means they are part of the public interface of kdelibs and we have to keep compatibility. Committing there also has the potential to break the build of whole KDE for everybody.
 When committing changes in kdelibs/cmake/modules/, the following rules must be followed:

@@ Line 3: / Line 3: @@
 The files located in kdelibs/cmake/modules/ are installed and can be used by other application. This means they are part of the public interface of kdelibs and we have to keep compatibility. Committing there also has the potential to break the build of whole KDE for everybody.
-When committing changes thereHere is the proposal for a commit policy for kdelibs/cmake/modules/ :
+When committing changes in kdelibs/cmake/modules/, the following rules must be followed:
 # '''Adding new files''': new files must be sent to kde-buildsystem@kde.org for review. They may only be added after an explicit Ok.

@@ Line 6: / Line 6: @@
 When committing changes thereHere is the proposal for a commit policy for kdelibs/cmake/modules/ :
-# Adding new files: new files must be sent to kde-buildsystem@kde.org for review. They may only be added after an explicit Ok.
+# '''Adding new files''': new files must be sent to kde-buildsystem@kde.org for review. They may only be added after an explicit Ok.
-# Patches which refactor multiple modules at once or which change how something is done in general for multiple files must be posted first. They may only be committed after an explicit Ok.
+# Patches which '''refactor multiple modules''' at once or which change how something is done in general for multiple files must be posted first. They may only be committed after an explicit Ok.
-# Adding public macros or functions: they must be posted for review first. If there is NO answer at all within two weeks they may be committed anyway.
+# '''Adding public macros or functions''': they must be posted for review first. If there is NO answer at all within two weeks they may be committed anyway.
 # Documentation must never be removed as long as it is valid and not replaced.
-# Other patches can always be committed.
+# Other patches can always be committed without review.
 # All patches must maintain [[Policies/CMake_and_Source_Compatibility|source compatibility]].
 # All patches must follow the [[Policies/CMake_Coding_Style|coding style]] for CMake files in KDE.