Difference between revisions of "Policies/CMake Commit Policy"

Jump to: navigation, search
Line 6: Line 6:
 
When committing changes thereHere is the proposal for a commit policy for kdelibs/cmake/modules/ :
 
When committing changes thereHere is the proposal for a commit policy for kdelibs/cmake/modules/ :
  
# Adding new files: new files must be sent to kde-buildsystem@kde.org for review. They may only be added after an explicit Ok.  
+
# '''Adding new files''': new files must be sent to kde-buildsystem@kde.org for review. They may only be added after an explicit Ok.  
# Patches which refactor multiple modules at once or which change how something is done in general for multiple files must be posted first. They may only be committed after an explicit Ok.
+
# Patches which '''refactor multiple modules''' at once or which change how something is done in general for multiple files must be posted first. They may only be committed after an explicit Ok.
# Adding public macros or functions: they must be posted for review first. If there is NO answer at all within two weeks they may be committed anyway.
+
# '''Adding public macros or functions''': they must be posted for review first. If there is NO answer at all within two weeks they may be committed anyway.
 
# Documentation must never be removed as long as it is valid and not replaced.
 
# Documentation must never be removed as long as it is valid and not replaced.
# Other patches can always be committed.
+
# Other patches can always be committed without review.
 
# All patches must maintain [[Policies/CMake_and_Source_Compatibility|source compatibility]].
 
# All patches must maintain [[Policies/CMake_and_Source_Compatibility|source compatibility]].
 
# All patches must follow the [[Policies/CMake_Coding_Style|coding style]] for CMake files in KDE.
 
# All patches must follow the [[Policies/CMake_Coding_Style|coding style]] for CMake files in KDE.

Revision as of 17:42, 29 March 2009

The files located in kdelibs/cmake/modules/ are installed and can be used by other application. This means they are part of the public interface of kdelibs and we have to keep compatibility. Committing there also has the potential to break the build of whole KDE for everybody.

When committing changes thereHere is the proposal for a commit policy for kdelibs/cmake/modules/ :

  1. Adding new files: new files must be sent to kde-buildsystem@kde.org for review. They may only be added after an explicit Ok.
  2. Patches which refactor multiple modules at once or which change how something is done in general for multiple files must be posted first. They may only be committed after an explicit Ok.
  3. Adding public macros or functions: they must be posted for review first. If there is NO answer at all within two weeks they may be committed anyway.
  4. Documentation must never be removed as long as it is valid and not replaced.
  5. Other patches can always be committed without review.
  6. All patches must maintain source compatibility.
  7. All patches must follow the coding style for CMake files in KDE.

KDE® and the K Desktop Environment® logo are registered trademarks of KDE e.V.Legal