Development/Tutorials/Common Programming Mistakes - Revision history

AnneW at 18:06, 13 July 2012

2012-07-13T18:06:46Z

Icwiener: Fix syntax highlighting.

2011-06-27T13:09:08Z

Fix syntax highlighting.

Show changes

Alisha at 15:24, 9 December 2009

2009-12-09T15:24:08Z

Tampakrap: class variable_name(); is a common C++ error ; you connot put parenthesis when declaring a variable on the stack ; try, it won't compile [deronnax@gmail.com]

2009-09-18T10:28:30Z

class variable_name(); is a common C++ error ; you connot put parenthesis when declaring a variable on the stack ; try, it won't compile [deronnax@gmail.com]

Milianw: /* Constant data */

2009-07-16T12:35:48Z

‎Constant data

Thiago: Fix the link I've just added

2009-05-08T21:43:53Z

Fix the link I've just added

Thiago: Add information about unmarked members, d-pointers and underscore being reserved.

2009-05-08T21:42:09Z

Add information about unmarked members, d-pointers and underscore being reserved.

Thiago: Fix the iterator erasing example. The erase() function returns the iterator to the next element.

2009-05-08T21:31:33Z

Fix the iterator erasing example. The erase() function returns the iterator to the next element.

Tampakrap: Fix delayed initialization link

2009-04-07T20:00:41Z

Fix delayed initialization link

Majewsky: /* memory leaks */ - auto_ptr is a solution

2009-01-04T00:33:14Z

‎memory leaks: - auto_ptr is a solution

← Older revision		Revision as of 18:06, 13 July 2012
Line 1:		Line 1:
−	~~{{Template:I18n/Language Navigation Bar\|Development/Tutorials/Common Programming Mistakes}}~~	+

	{{TutorialBrowser\|		{{TutorialBrowser\|

@@ Line 101: / Line 101: @@
 </code>
-See the [http://www.englishbreakfastnetwork.org/apidocs/apidox-kde-4.0/kdelibs-apidocs/kdecore/html/kglobal_8h.html#75ca0c60b03dc5e4f9427263bf4043c7 API documentation] for <tt>K_GLOBAL_STATIC</tt> for more information.
+See the [http://api.kde.org/4.x-api/kdelibs-apidocs/kdecore/html/group__KDEMacros.html#ga75ca0c60b03dc5e4f9427263bf4043c7 API documentation] for <tt>K_GLOBAL_STATIC</tt> for more information.
 === Constant data ===

@@ Line 251: / Line 251: @@
 would become
 <code cppqt>
-   t polluter();
+   t polluter;
 </code>
 * delete polluter using the complementing function to new:

@@ Line 111: / Line 111: @@
 Define the constant data using the language constructs of C++, not the preprocessor instructions, like you may be used to from plain C. This way the compiler can help you to find mistakes by doing type checking.
-<code cppqt>
+<code cppqt n>
 // Correct!
 static const int AnswerToAllQuestions = 42;

@@ Line 61: / Line 61: @@
 * '''_variable''' underscore and the name of variable starting with a lowercase letter. This style is actually usually frowned upon as this notation is also used in some code for function parameters instead.
-Unmarked members are more common in the case of classes that use [[Library Code Policy#D-Pointers|d-pointers]].
+Unmarked members are more common in the case of classes that use [[Policies/Library Code Policy#D-Pointers|d-pointers]].
 As it often happens there is not one correct way of doing it, so remember to always follow the syntax used by the application/library to which you are committing. If you're creating a new file, you may want to follow the coding style of the library or module you're adding the file to.

@@ Line 54: / Line 54: @@
 === Member variables ===
-You will encounter four major styles of marking class member variables in KDE:
+You will encounter four major styles of marking class member variables in KDE, besides unmarked members:
 * '''m_variable''' lowercase m, underscore and the name of the variable starting with a lowercase letter. This is the most common style and one prefered for code in kdelibs.
 * '''mVariable''' lowercase m and the name of variable starting with a uppercase letter
 * '''variable_''' variable name starting with a lowercase letter and then an underscore
 * '''_variable''' underscore and the name of variable starting with a lowercase letter. This style is actually usually frowned upon as this notation is also used in some code for function parameters instead.
-As it often happens there is not one correct way of doing it, so remember to always follow the syntax used by the application/library to which you are committing.
+Unmarked members are more common in the case of classes that use [[Library Code Policy#D-Pointers|d-pointers]].
 === Static variables ===

@@ Line 190: / Line 190: @@
 QMap<int, Job *>::iterator itEnd = m_activeTimers.end();
-for( ; it!=itEnd ; ++it )
+for( ; it != itEnd ; ++it) {
      if(it.value() == job) {
      if(it.value() == job)
-−
          //A timer for this job has been found. Let's stop it.
          killTimer(it.key());
@@ Line 205: / Line 203: @@
 <code cppqt>
 QMap<int, Job *>::iterator it = m_activeTimers.begin();
-while (it != m_activeTimers.end())
+while (it != m_activeTimers.end()) {
+     if(it.value() == job) {
-    QMap<int, Job *>::iterator prev = it;
-    ++it;
-     if(prev.value() == job)
-−
          //A timer for this job has been found. Let's stop it.
-         killTimer(prev.key());
+         killTimer(it.key());
-         m_activeTimers.erase(prev);
+         it = m_activeTimers.erase(it);
+     }
+}

@@ Line 287: / Line 287: @@
 === Delayed Initialization ===
-Although the design of modern C++ applications can be very complex, one recurring problem, which is generally easy to fix, is not using the technique of [http://www.kdedevelopers.org/node/view/509 delayed initialization].
+Although the design of modern C++ applications can be very complex, one recurring problem, which is generally easy to fix, is not using the technique of [http://www.kdedevelopers.org/node/509 delayed initialization].
 First, let us look at the standard way of initializing a KDE application:

@@ Line 256: / Line 256: @@
 <code cppqt>
    delete polluter;
 </code>
 A tool to detect memory leaks like this is [[Development/Tools/Valgrind|Valgrind]].
 === dynamic_cast ===