Development/Review Board - Revision history

Fengchao: /* Closing a review request */ Add --interactive to Add REVIEW keyword

2013-04-10T13:39:09Z

‎Closing a review request: Add --interactive to Add REVIEW keyword

Mechanical snail: /* Using post-review to post changes for review */ add corresponding package name for debian/ubuntu

2012-09-11T04:59:11Z

‎Using post-review to post changes for review: add corresponding package name for debian/ubuntu

Dfaure: formatting again (sorry)

2012-07-13T21:21:58Z

formatting again (sorry)

Dfaure: fix formatting

2012-07-13T21:20:27Z

fix formatting

Dfaure: document hack for making review-tool work with kde: remotes.

2012-07-13T21:18:53Z

document hack for making review-tool work with kde: remotes.

Esken: Closing a review request: Notes about differences between SVN and GIT commits

2011-10-30T20:01:30Z

Closing a review request: Notes about differences between SVN and GIT commits

Pippin: /* Create a convenient git alias */

2011-08-26T14:43:24Z

‎Create a convenient git alias

Sandstrom: Add a section on creating a Git alias for post-review

2011-06-28T21:10:38Z

Add a section on creating a Git alias for post-review

Odysseus: /* Using post-review to post changes for review */

2011-06-10T18:32:22Z

‎Using post-review to post changes for review

Odysseus: /* KDE Review Board */

2011-06-10T18:31:58Z

‎KDE Review Board

← Older revision		Revision as of 13:39, 10 April 2013
Line 95:		Line 95:

	in your commit. A message will also be posted to ReviewBoard indicating the commit SHA1 that closed the request. Please note that this only works for GIT commits, and not for Subversion commits.		in your commit. A message will also be posted to ReviewBoard indicating the commit SHA1 that closed the request. Please note that this only works for GIT commits, and not for Subversion commits.
		+
		+	You can use this command to add REVIEW keyword to existing git log:
		+	git rebase --interactive

	== Using Review Board With Subversion ==		== Using Review Board With Subversion ==

@@ Line 27: / Line 27: @@
 === Using post-review to post changes for review ===
-Once you are done with the above, it is time to post the changes to ReviewBoard. The easiest and most comfortable way to do that is <tt>[http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/ post-review]</tt>, a handy command line tool which takes care of creating review requests for you. This is normally in a package called RBTools (openSuse has a 1-click package in the [http://software.opensuse.org/search?q=rbtools devel:tools repository])
+Once you are done with the above, it is time to post the changes to ReviewBoard. The easiest and most comfortable way to do that is <tt>[http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/ post-review]</tt>, a handy command line tool which takes care of creating review requests for you. This is normally in a package called RBTools, available as [http://software.opensuse.org/search?q=rbtools <code>rbtools</code> in OpenSuse's devel:tools repository] and [apt://python-rbtools <code>python-rbtools</code> in Debian/Ubuntu].
 ==== Prerequisites ====

@@ Line 46: / Line 46: @@
 If your <tt>origin</tt> remote was already using the git:// url, substitute <tt>anonupstream</tt> with <tt>origin</tt> throughout the rest of this tutorial.
-If you used a kde: prefix for your git remotes, post-review won't expand it (it uses <tt>git config --get remote.origin.url</tt>). This can be fixed by editing  <tt>/usr/local/lib/python2.7/site-packages/RBTools-0.4.1-py2.7.egg/rbtools/clients/git.py</tt> and at the end of the function "def get_origin", adding the line
+If you used a <tt>kde:</tt> prefix for your git remotes, post-review won't expand it (it uses <tt>git config --get remote.origin.url</tt>).
 <tt>origin_url = origin_url.replace("kde:", "git://anongit.kde.org/")</tt>
 ==== Creating the review request ====

@@ Line 46: / Line 46: @@
 If your <tt>origin</tt> remote was already using the git:// url, substitute <tt>anonupstream</tt> with <tt>origin</tt> throughout the rest of this tutorial.
-If you used a kde: prefix for your git remotes, post-review won't expand it (it uses <tt>git config --get remote.origin.url</tt>). This can be fixed by editing  /usr/local/lib/python2.7/site-packages/RBTools-0.4.1-py2.7.egg/rbtools/clients/git.py and at the end of the function "def get_origin", adding the line <tt>origin_url = origin_url.replace("kde:", "git://anongit.kde.org/")</tt> before the return line.
+If you used a kde: prefix for your git remotes, post-review won't expand it (it uses <tt>git config --get remote.origin.url</tt>). This can be fixed by editing  <tt>/usr/local/lib/python2.7/site-packages/RBTools-0.4.1-py2.7.egg/rbtools/clients/git.py</tt> and at the end of the function "def get_origin", adding the line
 ==== Creating the review request ====

← Older revision		Revision as of 21:18, 13 July 2012
Line 45:		Line 45:

	If your <tt>origin</tt> remote was already using the git:// url, substitute <tt>anonupstream</tt> with <tt>origin</tt> throughout the rest of this tutorial.		If your <tt>origin</tt> remote was already using the git:// url, substitute <tt>anonupstream</tt> with <tt>origin</tt> throughout the rest of this tutorial.
		+
		+	If you used a kde: prefix for your git remotes, post-review won't expand it (it uses <tt>git config --get remote.origin.url</tt>). This can be fixed by editing /usr/local/lib/python2.7/site-packages/RBTools-0.4.1-py2.7.egg/rbtools/clients/git.py and at the end of the function "def get_origin", adding the line <tt>origin_url = origin_url.replace("kde:", "git://anongit.kde.org/")</tt> before the return line.

	==== Creating the review request ====		==== Creating the review request ====

@@ Line 83: / Line 83: @@
 === Closing a review request ===
-To close a review request, you can either use the ReviewBoard web interface or more conveniently, right in a commit. This is done by using the REVIEW keyword followed by the review ID you want to close. For example, to close review 54, you would put
+A review request can be closed in two ways. Either the user who opened the review request can use the ReviewBoard web interface. Or you close the review right in a GIT commit. This is done by using the REVIEW keyword followed by the review ID you want to close. For example, to close review 54, you would put
   REVIEW: 54
-in your commit. A message will also be posted to ReviewBoard indicating the commit SHA1 that closed the request.
+in your commit. A message will also be posted to ReviewBoard indicating the commit SHA1 that closed the request. Please note that this only works for GIT commits, and not for Subversion commits.
 == Using Review Board With Subversion ==

@@ Line 67: / Line 67: @@
 below to the <tt>[alias]</tt> section of your ~/.gitconfig file.
-  post-review = !post-review --guess-summary --guess-description --username=<YOUR USERNAME> --parent=master --tracking-branch=origin/master
+  post-review = !post-review --guess-summary --guess-description --username=<YOUR USERNAME> --parent=master --tracking-branch=anonupstream/master
 Now you can submit a committed patch for review by just typing

@@ Line 61: / Line 61: @@
   post-review --parent=master --tracking-branch=anonupstream/master -r 54
 ==== Creating a ReviewBoard-compatible diff ====
@@ Line 75: / Line 88: @@
 in your commit. A message will also be posted to ReviewBoard indicating the commit SHA1 that closed the request.
 == Using Review Board With Subversion ==

@@ Line 7: / Line 7: @@
 * [http://svn.reviewboard.kde.org KDE Subversion Review Board]
-Note that currently http://reviewboard.kde.org/ defaults to the Subversion version but this is scheduled to change so it is recommended to always use the git or svn prefix to be sure.
+Note that http://reviewboard.kde.org/ redirects to the Git version.
-== Using ReviewBoard and post-review with Git ==
+== Using Review Board and post-review with Git ==
 Every Git Project repository has its own entry on the KDE Git Review Board.
@@ Line 19: / Line 19: @@
 Before proceeding it is good practice to rebase your branch onto the branch you want to target for the merge. So, supposing you want to target <tt>master</tt>, make sure it is up-to-date with the remote and then run, and want to publish a review for a local branch:
-  git rebase master
+  git pull --rebase
 If you want to post a review for merging a non local branch, you might want to run the following: